<div dir="ltr">Thanks<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Dec 12, 2014 at 5:21 PM, Dagfinn Ilmari Mannsåker <span dir="ltr"><<a href="mailto:ilmari@ilmari.org" target="_blank">ilmari@ilmari.org</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Duncan Garland <<a href="mailto:duncan.garland@motortrak.com">duncan.garland@motortrak.com</a>> writes:<br>
<br>
> Hi,<br>
><br>
><br>
> Can somebody explain why I've started to get this warning when I run the<br>
> statement below.<br>
><br>
> As far as I can see, I'm doing exactly as asked, and the code works so it<br>
> doesn't evaluate to 1=1.<br>
<br>
It doesn't evaluate to literally "1=1", but by default array refs are<br>
ORed, so it evaluates to 'foo != x OR foo != y', which is always true<br>
if x != y.<br>
<br>
> SQL::Abstract::belch(): [SQL::Abstract::_where_field_op_ARRAYREF] Warning:<br>
> A multi-element arrayref as an argument to the inequality op '!=' is<br>
> technically equivalent to an always-true 1=1 (you probably wanted to say<br>
> ...{ $inequality_op => [ -and => @values ] }... instead)<br>
<br>
Note it says @values, not \@values. [ -and => ... ] and [ -or => ... ]<br>
only override the operator used between the rest of the values in that<br>
same array, not recursively into contained arrays.<br>
<br>
> my @service_contracts = $c->model('DB::Mbfl2ServiceContract')->search(<br>
> { vehicle_id => $vehicle_id,<br>
> deleted_yn => 'N',<br>
> status => { '!=' => [ '-and' => [ 'T', 'X', 'E' ] ] }<br>
<br>
If you run this with DBIC_TRACE=1, you'll see this renders as<br>
<br>
status != ? OR status != ? OR status != ?<br>
<br>
If you'd had [ -and => [...], [...] ] you would have seen it more clearly<br>
<br>
(status != ? OR status != ?) AND (status != ? OR status != ?)<br>
<br>
What you actually want is:<br>
<br>
status => { '!=' => [ '-and' => 'T', 'X', 'E' ] }<br>
<br>
Which renders as<br>
<br>
status != ? AND status != ? AND status != ?<br>
<br>
Hope this clarifies things.<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
"The surreality of the universe tends towards a maximum" -- Skud's Law<br>
"Never formulate a law or axiom that you're not prepared to live with<br>
the consequences of." -- Skud's Meta-Law<br>
<br>
<br>
_______________________________________________<br>
List: <a href="http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class" target="_blank">http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class</a><br>
IRC: <a href="http://irc.perl.org#dbix-class" target="_blank">irc.perl.org#dbix-class</a><br>
SVN: <a href="http://dev.catalyst.perl.org/repos/bast/DBIx-Class/" target="_blank">http://dev.catalyst.perl.org/repos/bast/DBIx-Class/</a><br>
Searchable Archive: <a href="http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk" target="_blank">http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk</a><br>
</font></span></blockquote></div></div>
<br>
<font face="Arial" size="1" style="color:rgb(34,34,34);background-color:rgb(255,255,255)"><font color="#808080">The information contained in this message is for the intended addressee only and may contain confidential and/or privileged information. If you are not the intended addressee, please delete this message and notify the sender; do not copy or distribute this message or disclose its contents to anyone. Any views or opinions expressed in this message are those of the author and do not necessarily represent those of Motortrak Limited or of any of its associated companies. No reliance may be placed on this message without written confirmation from an authorised representative of the company.</font></font><div style="color:rgb(34,34,34);font-family:arial,sans-serif;background-color:rgb(255,255,255)"><font color="#808080"><font face="Arial" size="1"><br>Registered in England 3098391 V.A.T. Registered No. 667463890</font></font></div>