<div dir="ltr"><div class="gmail_default" style="font-size:small">If they were dumped as comments rather than strings, then there would be no runtime impact, but you still get the documentation benefit. I'd certainly make use of such an option, as I sometimes perform a dump just to confirm that there were no surprising side effects to a change I made, and do not commit the output.<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Jul 21, 2017 at 3:14 PM, Francisco Obispo <span dir="ltr"><<a href="mailto:francisco@obispo.link" target="_blank">francisco@obispo.link</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 21 Jul 2017, at 12:33, Matt S Trout wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Fri, Jul 21, 2017 at 10:44:55AM -0700, Francisco Obispo wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I created an RT ticket (I don’t know if it’s the right place), to<br>
document this behavior which I believe is a bug:<br>
<br>
<a href="https://rt.cpan.org/Public/Bug/Display.html?id=122544" rel="noreferrer" target="_blank">https://rt.cpan.org/Public/Bug<wbr>/Display.html?id=122544</a><br>
</blockquote>
<br>
dbicdump is part of DBIx::Class::Schema::Loader not DBIx::Class itself<br>
<br>
</blockquote>
<br></span>
Yes, but wasn’t sure were to post the request.<span class=""><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The result is that `.pm`’s derived from a view from `dbicdump` are<br>
larger than they need to be, inherently using more memory, and with<br>
no real good purpose. There should be an option to turn this<br>
behavior off.<br>
</blockquote>
<br>
While I don't see any reason we wouldn't take a patch to supply such an<br>
option, I confess to being surprised that this was noticeable - how did<br>
you measure the memory usage with and without, and how big was the<br>
difference?<br>
<br>
</blockquote>
<br></span>
The diffs in git started getting very big all of the sudden, and in the company that I work, that started raising questions on the QA team, plus we have some areas where we have fairly large postgres views whose complexity is completely abstracted in a simple structure that has no interest to the ORM.<br>
<br>
Those fairly large views, force us to store the definition in RAM (as a perl string) now just for the sake of documentation, but in reality, at least in our system, is the wrong place to store the view definition. I don’t want to have to explain a more junior developer that the real view lives in SQL, and what lives in the .PM is just a snapshot of how it looked when the schema was dumped.<br>
<br>
I’m not saying it might not be useful for a lot of people, but for us is not and I would like to have a switch to turn it off if the desire is to leave it on by default, which again, I would advocate to do it the other way around.<br>
<br>
best regards,<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-- <br>
Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue<br>
<br>
<a href="http://shadowcat.co.uk/blog/matt-s-trout/" rel="noreferrer" target="_blank">http://shadowcat.co.uk/blog/ma<wbr>tt-s-trout/</a> <a href="http://twitter.com/shadowcat_mst/" rel="noreferrer" target="_blank">http://twitter.com/shadowcat_<wbr>mst/</a><br>
<br>
Email me now on mst (at) <a href="http://shadowcat.co.uk" rel="noreferrer" target="_blank">shadowcat.co.uk</a> and let's chat about how our CPAN<br>
commercial support, training and consultancy packages could help your team.<br>
<br>
______________________________<wbr>_________________<br>
List: <a href="http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class" rel="noreferrer" target="_blank">http://lists.scsys.co.uk/cgi-b<wbr>in/mailman/listinfo/dbix-class</a><br>
IRC: <a href="http://irc.perl.org#dbix-class" rel="noreferrer" target="_blank">irc.perl.org#dbix-class</a><br>
SVN: <a href="http://dev.catalyst.perl.org/repos/bast/DBIx-Class/" rel="noreferrer" target="_blank">http://dev.catalyst.perl.org/r<wbr>epos/bast/DBIx-Class/</a><br>
Searchable Archive: <a href="http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk" rel="noreferrer" target="_blank">http://www.grokbase.com/group/<wbr>dbix-class@lists.scsys.co.uk</a><br>
</blockquote>
<br>
______________________________<wbr>_________________<br>
List: <a href="http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class" rel="noreferrer" target="_blank">http://lists.scsys.co.uk/cgi-b<wbr>in/mailman/listinfo/dbix-class</a><br>
IRC: <a href="http://irc.perl.org#dbix-class" rel="noreferrer" target="_blank">irc.perl.org#dbix-class</a><br>
SVN: <a href="http://dev.catalyst.perl.org/repos/bast/DBIx-Class/" rel="noreferrer" target="_blank">http://dev.catalyst.perl.org/r<wbr>epos/bast/DBIx-Class/</a><br>
Searchable Archive: <a href="http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk" rel="noreferrer" target="_blank">http://www.grokbase.com/group/<wbr>dbix-class@lists.scsys.co.uk</a></div></div></blockquote></div><br></div>