<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">On Aug 2, 2017, at 16:38 , Francisco Obispo <<a href="mailto:francisco@obispo.link" class="">francisco@obispo.link</a>> wrote:<br class=""><div><blockquote type="cite" class=""><span style="font-family: sans-serif;" class="">Any thoughts on the </span><a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/13" class="">PR</a><span style="font-family: sans-serif;" class=""> ?</span></blockquote><br class=""></div><div>Functionally it looks sane to me, by quick inspection. A few review notes on style and process:</div><div><br class=""></div><div>• At the very least, it should be reduced to the single real commit, instead of commit A, revert of A, commit B.</div><div>• The maintainers may require you to add tests for this new option.</div><div>• The maintainers would likely appreciate if you matched the surrounding code style, particularly with regard to indentation levels and brace hugging.</div><br class=""><div class="">Cheers,</div><div class="">Thomas</div></body></html>