[html-formfu] Extremly simple patch to HTML::FormFu::Model::DBIC

[Zbigniew Lukasiak]

Hi Alex,

First thanks for finding the bug and for sending us the patch.   I am
sure that someone will apply it to the svn trunk at some time.  But if
you wan to happen sooner than  please make it easy for the commiters
and send us a patch in the form of svn diff from the current trunk.
To do it you need to:
- svn checkout the current trunk
- add your test to the t directory
- check if it fails
- make your changes
- check that the test does not fail any more
- run svn diff > yourpatch.diff

Then send us the yourpatch.diff file and it will be very easy for us
to check it and apply.

Cheers,
Zbigniew


On Wed, Apr 2, 2008 at 11:35 AM, Alex Povolotsky <tarkhil at over.ru> wrote:
> Carl Franks wrote:
>
> > On 02/04/2008, Alex Povolotsky <tarkhil at over.ru> wrote:
> >
> >
> > > solving a problem with many_to_many, defaults_from_model and
> store_to_model
> > > at once.
> > >
> > >  --- DBIC.pm~    2008-04-01 15:56:34.000000000 +0400
> > >  +++ DBIC.pm     2008-04-02 12:45:10.000000000 +0400
> > >  @@ -181,7 +181,7 @@
> > >                = exists $field->db->{default_column}
> > >                ? $field->db->{default_column}
> > >                :
> > > $dbic->$name->result_source->primary_columns;
> > >  -            my @defaults =
> > > $dbic->$name->get_column($col)->all;
> > >  +            my @defaults =
> > > $dbic->$name->get_column('me.'.$col)->all;
> > >            $field->default( \@defaults );
> > >      }
> > >    }
> > >
> > >
> > >  I do not know if it is a HTML::FormFu fail, or DBIx::Class fail; but
> I've
> > > found a place to fix it. It works.
> > >
> > >
> >
> > Hi,
> >
> > Can you send a patch against svn trunk? [1]
> > The code has changed so much that there's nothing in DBIC.pm that
> > looks anything like that anymore, so I can't tell where it's supposed
> > to go.
> >
> > We'll also need a test file that fails without the patch, so we know
> > what it's meant to be fixing.
> >
> >
>  Well... Here is a cruelly hacked test case from HTML::FormFu. It works with
> my patch, fails without it.
>
>  Alex
>
>
> _______________________________________________
>  HTML-FormFu mailing list
>  HTML-FormFu at lists.rawmode.org
>  http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/html-formfu
>



-- 
Zbigniew Lukasiak
http://brudnopis.blogspot.com/