[html-formfu] [patch] Change eval tests to use ref for big speed up in _Group.pm

Steve Nolte steve at redanvil.net
Wed Dec 2 17:25:00 GMT 2009


I noticed a big slow down when dealing with group-type fields that have a lot of options.  Tracked it down to the H::FF::E::_Group _parse_option() which was using eval's for testing if the item was a hash or array reference.  Switched it to just test with ref() and got a major speed up, about 1.5 to 2 seconds for some forms.

(BTW This is my first patch to a mailing list... hope it works!) 

-Steve
-------------- next part --------------
A non-text attachment was scrubbed...
Name: html_formfu_element__group.patch
Type: application/octet-stream
Size: 2055 bytes
Desc: html_formfu_element__group.patch
Url : http://lists.scsys.co.uk/pipermail/html-formfu/attachments/20091202/40bf245a/html_formfu_element__group.obj


More information about the HTML-FormFu mailing list