[Moose-commits] r7185 - Class-MOP/trunk

rafl at code2.0beta.co.uk rafl at code2.0beta.co.uk
Thu Dec 25 14:41:25 GMT 2008


Author: rafl
Date: 2008-12-25 06:41:24 -0800 (Thu, 25 Dec 2008)
New Revision: 7185

Modified:
   Class-MOP/trunk/MOP.xs
Log:
Remove prototypes from MOP.xs. The pure perl implementations don't have prototypes either.

The prototype for get_code_info remains as Sub::Identify::get_code_info, which
is used if we couldn't load our xs code, also has a prototype.

Modified: Class-MOP/trunk/MOP.xs
===================================================================
--- Class-MOP/trunk/MOP.xs	2008-12-25 14:00:04 UTC (rev 7184)
+++ Class-MOP/trunk/MOP.xs	2008-12-25 14:41:24 UTC (rev 7185)
@@ -327,12 +327,13 @@
     associated_metaclass = newSVpvs("associated_metaclass");
 
 
-PROTOTYPES: ENABLE
+PROTOTYPES: DISABLE
 
-
+# use prototype here to be compatible with get_code_info from Sub::Identify
 void
 get_code_info(coderef)
     SV *coderef
+    PROTOTYPE: $
     PREINIT:
         char *pkg  = NULL;
         char *name = NULL;
@@ -343,8 +344,6 @@
             PUSHs(newSVpv(name, 0));
         }
 
-PROTOTYPES: DISABLE
-
 void
 is_class_loaded(klass=&PL_sv_undef)
     SV *klass
@@ -396,13 +395,10 @@
 
 MODULE = Class::MOP   PACKAGE = Class::MOP::Package
 
-PROTOTYPES: ENABLE
-
 void
 get_all_package_symbols(self, filter=TYPE_FILTER_NONE)
     SV *self
     type_filter_t filter
-    PROTOTYPE: $;$
     PREINIT:
         HV *stash = NULL;
         HV *symbols = NULL;




More information about the Moose-commits mailing list