[OSUNIX-dev] OpenSolaris open64 port - 1st round patch review

["C. Bergström"]

Hi everyone..

If anyone has a spare minute to review the my patch which ports Open64 
to OpenSolaris snv_107+.  It also contains most (not all) of the changes 
to complete the FreeBSD port.

http://pkg.osunix.org/open64/open64-opensolaris-fbsd-merged-3-3.diff.gz

342 files changed
258K open64-opensolaris-fbsd-merged-3-3.diff
Built with gcc version 4.4.0 20090130 (experimental) (GCC)


Questions:
1) Best way to replace /proc/cpuinfo for OpenSolaris?

opencc -v
opencc WARNING: cannot read /proc/cpuinfo, defaulting to basic 32-bit x86.
sh: line 1: /usr/local/src/bar/open64/usr/bin/gcc: not found
opencc ERROR: no support for GCC version 0
sh: line 1: /usr/local/src/bar/open64/usr/bin/gcc: not found
opencc INTERNAL ERROR: display_version: unexpected GCC version 0

Open64 Compiler Suite: Version 7.40
Built on: 2009-03-03 00:32:55 +0200
Thread model: posix
GNU gcc version 3.3.1 (Open64 4.2 driver)

Should I just #ifdef?
osprey/driver/opt_actions.c

2) The patch comments out building ld-new.  This needs to be fixed, but 
what's the best way to do this on OpenSolaris only?

3) Instead of creating solaris include directly I #ifdef elf_stuff and 
friends.  Better way?

4) I'd say 99% of the FreeBSD port is also included in this patch, but I 
was thinking to do the OpenSolaris port first and then in another patch 
finish the FreeBSD port

5) Need to detect OpenSolaris in the Makefile* so it calls hostname 
instead of hostname -f

6) The FreeBSD port work I merged had.  I reverted, but thoughts?

-         UINT64 esize = Get_Integer_Value (newesize) / BITSPERBYTE;
+         UINT64 esize = Get_Integer_Value (newesize) / BITSPERBYTE;

7) I didn't confirm, but ksh93 as /bin/sh causes a corruption on 
preg_list.h file creation


Thanks

./Christopher


ps.. Anyone with SPEC2006 feel like helping with some benchmarks?