[Perl-org-patches] Separated patches for www.perl.org

Matt S Trout mst at shadowcat.co.uk
Mon Sep 28 16:49:27 GMT 2009


On Tue, Sep 22, 2009 at 09:35:52PM +0100, Leo Lapworth wrote:
> Hi,
> 
> To help make reviewing easier I've broken out my big patch into 17 smaller
> ones and put in
> a comment at the top of each.
> 
> Thanks
> 
> Leo
> 
> PATCH 1) Refactor books.html - cleanout dead/old links, reorganise so the
> online library is more prominant
> 
> ----------- START -------
> === www/books.html
> ==================================================================
> --- www/books.html    (revision 78)
> +++ www/books.html    (revision 79)
> @@ -1,55 +1,111 @@
>  [% META title = 'Books & Articles' %]
>  [% page.style = "perl-directory.html" %]
>  [% page.sidebar = BLOCK %]
> -<DIV CLASS="NAVITEM">
> 
> -<H3>Free books!</H3>
> -<P>
> -Read perl books online in the updated <A
> -HREF="/books/library.html"><b>online library</b></A>.
> -</P>
> +<div class="NAVITEM">
> +    <h3>
> +        Free Perl books:
> +    </h3>
> +    <p>
> +        See the <a href="/books/library.html"><b>online Perl
> library</b></a>.
> +    </p>
> +    <h3>
> +        Randal's Articles
> +    </h3><a href="http://www.stonehenge.com/merlyn/columns.html">Browse
> Randal's articles at Stonehenge</a>.
> +    <p>
> +        Perl Wizard Randal Schwartz has written many articles to help Perl
> programmers at all levels. His articles have appeared in SysAdmin,
> WebTechniques, Unix Review, and more.
> +    </p>
> +</div>
> +<p>
> +    [% END %]
> +</p>
> 
> -   <H3>Randal's Articles</H3>
> -<a href="http://www.stonehenge.com/merlyn/columns.html">Browse Randal's
> articles at Stonehenge</a>.
> -<P>
> -Perl Wizard Randal Schwartz has written many articles to help
> -Perl programmers at all levels.  His articles have appeared in SysAdmin,
> -WebTechniques, Unix Review, and more.
> +<h3>
> +    Books
> +</h3>
> +<ul>
> +    <li>
> +        <a href="/books/library.html">Perl.org free online library</a>
> +    </li>
> +</ul>
> 
> -  </div>
> -[% END %]
> 
> -<P>
> -<h3>Magazines and Journals</h3>
> +<h3>
> +    Book recommendations
> +</h3>
>  <ul>
> -<LI><a href="http://www.perl.com">Perl.com</a> - articles on a variety
> -of Perl-related topics
> -<LI><a href="http://www.theperlreview.com">The Perl Review</a> - a magazine
> devoted to Perl
> -<LI><a href="http://www.perl-magazin.de">$foo (German Perl Magazine)</LI>
> -<LI><a href="http://www.perlcast.com">PerlCast</A> - a Perl podCast
> -<LI><a href="http://www.tpj.com">The Perl Journal</a> - a Perl focused
> magazine (1996-2006)
> -<LI><a href="http://www.stonehenge.com/merlyn/columns.html">Randal
> Schwartz' Articles</a>
> -<LI><a href="http://www.perlarchive.com/articles/perl/">The Perl Archive
> Articles</a> - the Learning Center's Perl Article index
> -<LI><a href="http://www.perlfect.com/articles/"> Perlfect Articles</a> -
> articles from Perlfect Solutions
> -<LI><a href="http://www.usenix.org/publications/perl/"> SAGE Perl
> Articles</a> - archived Perl Practicum articles from ;login 1993-1997
> +    <li>
> +        <a href="
> http://www.amazon.com/exec/obidos/tg/listmania/list-browse/-/HB1RWLRSGVKC/ref=cm_lm_dp_l_1/002-5179774-6132042">Dave
> Cross recommends ...</a>
> +    </li>
> +    <li>
> +        <a href="
> http://www.amazon.com/exec/obidos/tg/listmania/list-browse/-/2I3RK3EW6URXJ/qid=1031749291/sr=5-1/ref=sr_5_1/002-5179774-6132042">brian
> d foy recommends ...</a>
> +    </li>
>  </ul>
> 
> -<h3>Books</H3>
> +<h3>
> +    Articles, blogs and magazines
> +</h3>
>  <ul>
> -<li><a href="/books/library.html">The perl.org online library</a></li>
> -<li><a href="http://books.perl.org">Browse the book database at
> books.perl.org</a>
> -<LI><a href="
> http://www.amazon.com/exec/obidos/tg/listmania/list-browse/-/HB1RWLRSGVKC/ref=cm_lm_dp_l_1/002-5179774-6132042">Dave
> Cross recommends ...</a>
> -<LI><a href="
> http://www.amazon.com/exec/obidos/tg/listmania/list-browse/-/2I3RK3EW6URXJ/qid=1031749291/sr=5-1/ref=sr_5_1/002-5179774-6132042">brian
> d foy recommends ...</a>
> +    <li>
> +        <a href="http://www.perl.com">Perl.com</a> - articles on a variety
> of Perl-related topics
> +    </li>
> +    <li>
> +        <a href="http://planet.perl.org/">Planet Perl</a> - an aggregation
> of Perl blogs
> +    </li>

If we're including that planet, is it worth having perlsphere and ironman
in there as well?

> +    <li>
> +        <a href="http://www.theperlreview.com">The Perl Review</a> - a
> magazine devoted to Perl
> +    </li>
> +    <li>
> +        <a href="http://www.perl-magazin.de">$foo (German Perl
> Magazine)</a>
> +    </li>
> +    <li>
> +        <a href="http://www.stonehenge.com/merlyn/columns.html">Randal
> Schwartz' Articles</a>
> +    </li>
> +    <li>
> +        <a href="http://www.perlfect.com/articles/">Perlfect Articles</a> -
> articles from Perlfect Solutions
> +    </li>
>  </ul>
> 
> 
> -<h3>Larry Wall on Perl...</h3>
> +<h3>
> +    Audio
> +</h3>
>  <ul>
> -<li><a href="http://www.perl.com/pub/a/1999/03/pm.html">Perl, the first
> postmodern computer language</A>
> -<li><A href="http://www.oreilly.com/catalog/opensources/book/larry.html">Diligence,
> Patience, and Humility"</A>
> -    in Open Sources: Voices from the Open Source Revolution
> -<li><A href="http://www.amazon.com/exec/obidos/tg/feature/-/7137/">Amazon.com
> interview with Larry Wall</a>
> -<li><a href="http://www.linuxjournal.com/issue61/3394.html">Linux Journal
> interview</a> (May 1999)
> -<li><a href="
> http://archive.salon.com/21st/feature/1998/10/cov_13feature.html">The Joy Of
> Perl</A>
> +    <li>
> +        <a href="http://www.perlcast.com">PerlCast</a> - a Perl podCast
> +    </li>
> +    <li>
> +        <a href="http://perl.fm/">Perl.fm</a>
> +    </li>
>  </ul>
> 
> +<h3>
> +    Video
> +</h3>
> +<ul>
> +    <li>
> +        <a href="http://yapc.tv/">Talks from YAPC and other conferences</a>
> +    </li>
> +</ul>
> +
> +
> +<h3>
> +    Larry Wall on Perl...
> +</h3>
> +<ul>
> +    <li>
> +        <a href="http://www.perl.com/pub/a/1999/03/pm.html">Perl, the first
> postmodern computer language</a>
> +    </li>
> +    <li>
> +        <a href="http://www.oreilly.com/catalog/opensources/book/larry.html">Diligence,
> Patience, and Humility"</a> in Open Sources: Voices from the Open Source
> Revolution
> +    </li>
> +    <li>
> +        <a href="http://www.amazon.com/exec/obidos/tg/feature/-/7137/">Amazon.com
> interview with Larry Wall</a>
> +    </li>
> +    <li>
> +        <a href="http://www.linuxjournal.com/issue61/3394.html">Linux
> Journal interview</a> (May 1999)
> +    </li>
> +    <li>
> +        <a href="
> http://archive.salon.com/21st/feature/1998/10/cov_13feature.html">The Joy Of
> Perl</a>
> +    </li>
> +</ul>
> ----------- END -------
> 
> PATCH 2) Move the book list into page (rather than in the nav on the left)
> so it is easier to read and does not wrap.
> 
> PATCH 3) Cleanup HTML

Seem fine though a screenshot of the results or something might be nice.
 
> ----------- END -------
> 
> PATCH 4) Remove the copy for the Safari advert, the image is enough?

Approve.

> PATCH 5) 'Blogs' are more important than 'Articles' these days, and fresher

Agree.

> PATCH 6) Now we have book links in main body, we can have normal navigation
> on the left

Same thought as 2&3

> PATCH 7) Put stats into a separate file so easier to maintain, also update
> the figures

Awesome. Worth including more stats from timb's perl myths and barbie's
stuff?

> PATCH 8) Update events to include correct number of monger groups (from
> stats file)

Good.
 
> PATCH 9) Events - put monger groups first, review others and move calendar
> last (useful but distracting at top)

There's a list of conferences somebody did somewhere - worth incorporating?
 
> PATCH 13) Remove old release news

Can we dump the perl.com link unless ORA start maintaining it again?
 
No specific notes on the rest - seem sane to me.

-- 
        Matt S Trout         Catalyst and DBIx::Class consultancy with a clue
     Technical Director      and a commit bit: http://shadowcat.co.uk/catalyst/
 Shadowcat Systems Limited
  mst (@) shadowcat.co.uk        http://shadowcat.co.uk/blog/matt-s-trout/



More information about the Perl-org-patches mailing list