[Redis] DEV release with new network code

Ivan Kruglov ivan.kruglov at yahoo.com
Sun Apr 27 13:16:06 GMT 2014


Hi,
> Performance is seems about the same. Glancing throw the code I see
> you're using MSG_DONTWAIT which is not available on Windows, AFAIK. The
> whole __try_read_sock subroutine looks a bit inefficient to me, you are
> reading data with MSG_PEEK, just to check if there's any, and then you
> throwing it away. Why not save it into {__buf} and avoid reading it
> again?
Good points.
I've fixed both issues in my latest pull request 
(https://github.com/PerlRedis/perl-redis/pull/83).

Ivan.



More information about the Redis mailing list