[Catalyst-dev] Catalyst::Plugin::Server::XMLRPC fault code patch

[Alex Pavlovic]

Hi,

Here is the new patch, tabs removed, sorry for that as I am used to tabs 
because it allows for configurable number of spaces. ARRAY ref is being 
checked as well. One patch is supplied.

I also made it so that fault code and message can be sent to user even when 
show_errors is not in use. The user has to explicitly set a fault code and 
message in order for this to work. The reason for this is because sometimes 
you dont want all the faults to be visible to the client side such as DBI 
errors which may reveal potential database layout, but just the very few 
specific ones, this allows for that.


Cheers.

On Monday 17 July 2006 10:20, Matt S Trout wrote:
> Alex Pavlovic wrote:
> > Hi,
> >
> > Here is a test script "040_faultcode.t" which you can add to t,
> > and patch for t/lib/TestApp/Controller/RPC/Functions.pm, which
> > adds an extra "echo_fault" method to be used with the test script.
> >
> > Just ran everything and it works ok.
>
> Ok, both the authors of Server are away atm (one getting married, one on
> the trans-siberian express) but I managed to track the former down
> anyway (ta kane).
>
> Three things need doing -
>
> 1) you're assuming ->error contains an array ref if set; you need to
> check that to prevent stupid dies
> 2) your patches are full of tabs. please match the coding conventions of
> the original
> 3) random bits of patch are a pain to apply consistently, please provide
> a single (svn diff|svk diff|diff -ur) output instead please
>
> If you can sort the above three, I have a go-ahead to apply your change
> to trunk for the moment and the authors will audit it fully once they're
> back from holiday.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xmlrpc.patch
Type: text/x-diff
Size: 3472 bytes
Desc: not available
Url : http://lists.rawmode.org/pipermail/catalyst-dev/attachments/20060718/a13f3c76/attachment.bin