[Catalyst-dev] RFC: Secure attribute for actions (patch inside)

Jonathan Rockway jon at jrock.us
Sat Oct 21 17:04:35 CEST 2006


Did you test this?

> +        if ( length $self->attributes->{Secure} )
> +           $c->forward( $self->attributes->{Secure} );
> +       return 0; # don't match if Secure action && insecure pipe.

With regards to the patch in general, I don't think this functionality is so 
useful that every Catalyst class in existence (C::Base) needs the code, 
though.  Put it in a base class so that individual users can select which 
classes need the functionality,

If you do that, you don't even need our approval; you can just push it to CPAN 
yourself.  Not that anyone would have any problems putting /that dist/ in 
svn, though.

Also, unit tests are appreciated when submitting a patch.

Regards,
Jonathan Rockway

-- 
package JAPH;use Catalyst qw/-Debug/;($;=JAPH)->config(name => do {
$,.=reverse qw[Jonathan tsu rehton lre rekca Rockway][$_].[split //,
";$;"]->[$_].q; ;for 1..4;$,=~s;^.;;;$,});$;->setup;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 307 bytes
Desc: not available
Url : http://lists.rawmode.org/pipermail/catalyst-dev/attachments/20061021/2e9b8d98/attachment.pgp 


More information about the Catalyst-dev mailing list