[Catalyst-dev] Re: [Catalyst] Race condition inCatalyst::Plugin::Session and Catalyst::Engine::Apache(possibly other engines too)

[Matt Pitts]

> -----Original Message-----
> From: Tomas Doran [mailto:bobtfish at bobtfish.net]
> Sent: Wednesday, January 07, 2009 2:50 PM
> To: Development of the elegant MVC web framework
> Cc: Sergio Salvi; Matt Pitts; Bill Moseley
> Subject: Re: [Catalyst-dev] Re: [Catalyst] Race condition
> inCatalyst::Plugin::Session and Catalyst::Engine::Apache(possibly
other
> engines too)
> 
> On 12 Dec 2008, at 21:37, Sergio Salvi wrote:
> >
> > No worries. At least we know your app is also fine with the finalize
> > () patch.
> >
> > I've merged the two patches so now you shouldn't see the duplicate
> key
> > issue anymore:
> >
> > http://dev.catalyst.perl.org/svnweb/Catalyst/browse/branches/
> > Catalyst-Plugin-Session/both/
> >
> > Please note I haven't run this one in live production yet. I'll
> > probably get it in production at $work only in January because of
> > upcoming code freezes.
> 
> Okie dokie, hopefully a couple of people have tried this now - can I
> get a show of hands from people who've tried this?

I've been running finalize_race_condition for about a month now and I
put "both" patches in place a few days ago. I'm still having some major
session issues (see my post on the users list), but that was the reason
I applied the patches in the first place. I'm not sure if my app is a
good test of the patches, but they haven't caused any additional
problems.

> Assuming it has been at least a bit tested in real applications, I'll
> review, merge to trunk and push a dev release up to CPAN, then
> announce that we'd like people to test it on the normal Catalyst list
> so that we can get some testing from a wider audience before actually
> unleashing it on CPAN.
> 
> Does that sound like a sane plan to everyone?

Makes sense to me.

v/r
-matt