[Catalyst-dev] ACCEPT_CONTEXT broken against latest Catalyst

[Paul Makepeace]

Building against Catalyst 5.80005 we're seeing,

rpix:~/.cpan/build/Catalyst-Component-ACCEPT_CONTEXT-0.06-yVcsMJ# make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e"
"test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/00-load.t
t/01-live.t t/02-live-stash.t t/boilerplate.t t/mro-ok.t
t/pod-coverage.t t/pod.t t/preserve-object.t
t/00-load............ok 1/1# Testing
Catalyst::Component::ACCEPT_CONTEXT 0.06, Perl 5.010000, /usr/bin/perl
t/00-load............ok
t/01-live............ok
t/02-live-stash......ok
t/boilerplate........ok
t/mro-ok.............ok
t/pod-coverage.......skipped
        all skipped: Test::Pod::Coverage 1.04 required for testing POD coverage
t/pod................skipped
        all skipped: Test::Pod 1.14 required for testing POD
t/preserve-object....NOK 1/4
#   Failed test 'foo created'
#   at t/preserve-object.t line 10.
#          got: undef
#     expected: 'yes'
Can't use an undefined value as a HASH reference at t/preserve-object.t line 11.
# Looks like you planned 4 tests but ran 1.
# Looks like you failed 1 test of 1 run.
# Looks like your test exited with 255 just after 1.
t/preserve-object....dubious
        Test returned status 255 (wstat 65280, 0xff00)
DIED. FAILED tests 1-4
        Failed 4/4 tests, 0.00% okay
Failed Test         Stat Wstat Total Fail  List of Failed
-------------------------------------------------------------------------------
t/preserve-object.t  255 65280     4    7  1-4
2 tests skipped.
Failed 1/8 test scripts. 4/17 subtests failed.
Files=8, Tests=17,  9 wallclock secs ( 8.09 cusr +  0.42 csys =  8.51 CPU)
Failed 1/8 test programs. 4/17 subtests failed.
make: *** [test_dynamic] Error 255
rpix:~/.cpan/build/Catalyst-Component-ACCEPT_CONTEXT-0.06-yVcsMJ#

ACCEPT_CONTEXT.pm 0.05 built fine against an earlier Catalyst
5.8(0004) so I think this is quite recent. 0.05 against 5.80005 breaks
similarly and has the NEXT deprecation warnings.

I see this is failing in CPAN testers too -
http://www.nntp.perl.org/group/perl.cpan.testers/2009/06/msg4124101.html

What's the general feeling on ACCEPT_CONTEXT? The author seems to me
to give a pretty dim view of using the module ("WARNING", "hack", etc)
pushing InstancePerContext instead. Is ACCEPT_CONTEXT heading to
deprecation or are there specific use cases where it's appropriate
over I.P.C.?

P