[Catalyst] Suggested minor fixes for Catalyst error output

[luke saunders]

Sorry Nigel, I'd forgotten about your original patch.

> However TT is required by a cat install (used for the production of the
> initial app templates).  Maybe we could put the files out separately and
> process the error page through TT to pull them in?
> [This could also help in handling the differing licenses between
> NiftyCube (GPL) and Catalyst (Artistic & GPL)]

This probably is nicer than just lumping it all in Engine.pm. But then i
supposed Catalyst would REALLY rely on the skeleton of the App being created
with the helper script (so the error/welcome/javascript templates can be
deployed in root/templates/ or whatever, without which they'd get no error
at all).

I guess it is possible for just the Nifty JS library to be put in
root/static/js and then included using the same uri_for magic that the
welcome page uses for its images. But the fact remains, it's still yet more
stuff to ship with Cat and yet more stuff to put in the root/static
directories which probably isn't desirable.

So, they're just corners for the error page and they're a bit of a nightmare
so let's just ditch them. They can be left as they are on the welcome page
since that doesn't break.

On 4/13/06, Nigel Metheringham <Nigel.Metheringham at dev.intechnology.co.uk>
wrote:
>
> On Thu, 2006-04-13 at 11:25 +0100, luke saunders wrote:
> > I tried knocking up a patch using the NiftyCorners code as suggested
> > (http://pro.html.it/niftycube/) and though it appears to work it's
> > massive. I took everything that was needed from the source and put in
> > it Engine.pm and it's really bloated. See border_js.diff for the
> > nastiness in all its glory.
>
> Thats what I was thinking, although I had not had time to try coding
> anything.  Of course you cannot pull them in using a script tag since
> you cannot work with all the possible web server variations and you
> can't even include them in as you would in a TT page because you can't
> count on the user having a TT View installed.  (Same for Mason etc).
>
> However TT is required by a cat install (used for the production of the
> initial app templates).  Maybe we could put the files out separately and
> process the error page through TT to pull them in?
> [This could also help in handling the differing licenses between
> NiftyCube (GPL) and Catalyst (Artistic & GPL)]
>
> At least separating them out - or maybe encapsulating as in
> HTML::Prototype - makes the chunks reusable elsewhere.
>
> Of course, if we are using Nifty for corners, the original welcome page
> needs recoding too.
>
> > So given that the suggested JS solution is too big (+300 lines in
> > Engine.pm) and other JS solutions are also likely to be massive maybe
> > the corners should just be removed. border_no_corners.diff should take
> > care of this.
>
> Obviously I can go along with this as its what I initially suggested.
>
>         Nigel.
>
> --
> [ Nigel Metheringham           Nigel.Metheringham at InTechnology.co.uk ]
> [ - Comments in this message are my own and not ITO opinion/policy - ]
>
>
> _______________________________________________
> Catalyst mailing list
> Catalyst at lists.rawmode.org
> http://lists.rawmode.org/mailman/listinfo/catalyst
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.rawmode.org/pipermail/catalyst/attachments/20060413/da3a32bb/attachment.htm