[Catalyst] redirects and FastCGI in Catalyst 5.80030

[Pedro Melo]

Hi,

On Thu, Jan 27, 2011 at 10:27 AM, Tobias Klug <tklug at hartle-klug.de> wrote:
> Hello,
>
> I am new to this mailinglist, but have tried to find an answer to my
> question in the archives without success.
>
> I have a Catalyst-App running on a FastCGI deployment. Up until Catalyst
> 5.80029 everything worked fine. But since the new version Catalyst
> 5.80030 I get warnings on redirects such as this:
>
> [warn] mod_fcgid: stderr: Use of uninitialized value $buffer in
> concatenation (.) or string at
> /usr/local/share/perl/5.10.0/Catalyst/Engine/FastCGI.pm line 173.

This should solve the warning:

--- FastCGI.pm.orig	2011-01-27 10:36:43.000000000 +0000
+++ FastCGI.pm	2011-01-27 10:36:46.000000000 +0000
@@ -158,6 +158,7 @@

 sub write {
     my ( $self, $c, $buffer ) = @_;
+    $buffer = '' unless defined $buffer;

     unless ( $self->_prepared_write ) {
         $self->prepare_write($c);


Starting from 5.80030, the buffer can be undef.

I haven't tested the above patch, I don't use Engine::FastCGI.

Bye,
-- 
Pedro Melo
http://www.simplicidade.org/
xmpp:melo at simplicidade.org
mailto:melo at simplicidade.org