[Catalyst] prepare_body_chunk in Catalyst 5.9
ewright at linescale.com
Mon Jul 16 15:23:06 GMT 2012
Nope. I don't have a problem with making the change. I like the idea using
the role applicator so I can keep things neatly packaged in a separate
plugin. (One of those cases where the Plugin approach makes sense since I
am very interested in the request/response lifecycle.)
I think adding some notes regarding the change to Catalyst::Upgrading is a
good idea. The POD for Catalyst::Engine should also probably add a note
explaining its removal or with a link to Catalyst::Upgrading.
On Mon, Jul 16, 2012 at 11:09 AM, Tomas Doran <bobtfish at bobtfish.net> wrote:
> On 12 Jul 2012, at 21:42, Eric Wright wrote:
> > Looking into this further - in the the source for Catalyst I see that
> the prepare_body statement has been moved to the Request object removing
> the ability to hook into this event via the Plugin architecture. I was
> using this hook to monitor the number of chunks transmitted to the server
> for monitoring upload progress. I take it this approach is not going to be
> supported any longer? From a design perspective, would it be recommended
> that I instead extend and implement my own Request class for this purpose?
> Appreciate the feedback.
> <double sigh> - I accidentally didn't send this - less relevant now..
> bummer :(
> I'm responsible for the changes in question, and what you are doing is an
> entirely valid use-csse.
> To the wider community - is anyone else doing this?
> To you, Eric - do you have any logistical or cultural problem moving this
> functionality to a custom request class/role (role recommended)?
> As unless anyone disagrees (feel free if you think I'm wrong!), I think
> the change is actually good, and should stay (as only a very few people
> will be affected by it), but we should note it in Catalyst::Upgrading.
> List: Catalyst at lists.scsys.co.uk
> Listinfo: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/catalyst
> Searchable archive:
> Dev site: http://dev.catalyst.perl.org/
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Catalyst