[DBIx-Class-Devel] doc fixes

Peter Rabbitson rabbit+dbic at rabbit.us
Tue Dec 4 09:49:38 GMT 2012


On Tue, Dec 04, 2012 at 12:11:05AM -0500, Brendan Byrd wrote:
> On Mon, Dec 3, 2012 at 9:49 PM, Peter Rabbitson <rabbit+dbic at rabbit.us> wrote:
> > On Fri, Nov 30, 2012 at 09:34:50AM -0600, fREW Schmidt wrote:
> >
> > I *think* this branch (topic/doc_fixes) is fully included in
> > topic/docs-pod-inherit. I suggest not merging the former until the later
> > and then comparing what (if anything) is left.
> 
> It's not.  I specifically split rs_doc_fix2 into these two separate
> topics because the
> response I got from that former topic was something to the effect of "omg, too
> much stuff here".

It... is. The bulk of 383211ab7 is contained in 03bf20842a. In 
particular Relationship::Base/$relationship_accessor and the NOTE on top 
of ::Row are in both commits, with minor differences. Please double 
check.

> 
> > While we are on topic of review - Getty kept saying something about
> > autogenerating the copyrights, I don't know if he got anywhere with it.
> 
> *cough* DZIL *cough*

For starters - I hate distzilla. It is a badly architectured, 
overcomplicated heap of random code that may or may not produce what one 
needs in the end. Worse - if it produced what you want today, there is 
no guarantee it will keep doing that tomorrow, after some part of the 
CPAN half dzil depends on changes subtly. With that said - I have stated 
before that I will not oppose a switch to dzil for *distmaking only* if 
someone is willing to do the legwork and satisfy the following:

- Dzil is just a distbuilder - this means a checkout must be usable 
without it One must be able to patch/test/use a checkout without ever 
installing Dzil

- No moving target bundles - this means nothing beyond the most proven 
ones, and definitely no use of ::Bundle::<vanityname>. All plugins must 
be spelled out individually, to facilitate easy shutoff. The fails 
scenario here is e.g.: If I need to build a tarball urgently, only to 
discover that I need Net::Twitter and Facebook::API just to run `dzil 
build` I will cling to guns without the use of religion ;)

- All code must remain at its original site - the line numbers on CPAN 
must match the line numbers in master. PODmunging can only happen at the 
end of a .pm, nowhere else.

Beyond this - if people overwhelmingly want to use dzil - fine, use 
dzil. I still get to tease you all the time about it though.



More information about the DBIx-Class-Devel mailing list