[DBIx-Class-Devel] SQL::Statement-based driver support

[Brendan Byrd]

On Tue, Mar 19, 2013 at 4:20 AM, Peter Rabbitson <rabbit+dbic at rabbit.us>wro=
te:

>
> - Please get the thing green on travis for starters
>


- s/Storage::DBI::SQL::Statement/DBI::DBDFile/ - seems like the more logical
>   base class (while the SQLMaker is fine as-is)
>

> - Move the "no-bind-limit" copy into SQLMaker::SQLStatement - make it a
>   substituting wrapper around the original


> - The svp_begin is not necessary - by default a storage is assumed to not
>   support savepoints.


Will do.


> - We need to generate t/lib/test_deploy/DBICTest-Schema... - augment
>   maint/gen_schema (and the corresponding call in
>   maint/Makefile.PL.inc/56_autogen_testddl.pl)
>

What about static files?  You want me to just put the SQL file in maint/?


> - The txn_begin caller-guessing thing is a no-go. txn_begin needs to rema=
in
>   a noop with a carp_once "this driver can not support transactions
>   proceeding at your own risk" and a hard exception on a txn_rollback
>   "Unable to rollback - your data is likely inconsistent"
>

Does this include internal calls to txn?  In those cases, the user didn't
actually try to call a transaction, but calls like populate will run their
own transaction calls.


> - autoinc exception needs to move way earlier before the call, so that one
>   does not start inserting NULL's into columns marked is_auto_increment.
>   I will do a writeup towards the weekend of all column attrs DBIC
> currently
>   opportunisticaly uses, it will become more apparent then.
>

I'll take a look at that.


> - in t/86ss_csv.t you have f_ext =3D> ".csv/r" - is the odd name intentio=
nal?
>

https://metacpan.org/module/DBD::File#f_ext

The /r is an extra flag for the parameter.

-- =

Brendan Byrd <Perl at ResonatorSoft.org>
Brendan Byrd <BBYRD at CPAN.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/201303=
19/91cdd054/attachment.htm