[DBIx-Class-Devel] [dbix-class] Unbreak $rs->create() with empty hashref on Oracle (#61)

[Lasse Makholm]

On Wed, Oct 22, 2014 at 9:57 PM, Peter Rabbitson <notifications at github.com>
wrote:

> Hi @lasse-unity3d <https://github.com/lasse-unity3d>
>
> I had a chance to review your contribution after it was merged to the dev
> branch, and found some issues. Please read the detailed explanation here:
> f813551 <https://github.com/dbsrgits/dbix-class/commit/f8135512c>
>
Thanks for the explanation. I'm not nearly familiar enough with DBIC
internals yet to really grasp the implications of what you explained but
I'll try to read up on it.

Do you have concrete examples of breakage resulting from the patch? That
would be really helpful for me to understand the problem better...

> It would be great if you could spend some time to get the thing into
> shape, however given it has been a while it may be the case you no longer
> have the opportunity to work on this. Please let us know if this is the
> case, so someone else can pick it up and slog it to completion.
>
The issue is still relevant to me but since our porting to Oracle has been
postponed it's not my focus at the moment. We're in a bit of a crunch
currently but I'll try to get around to this again soon...

Vacation next week may or may not help with this... :-)

/L

> In any case: thanks for helping us make DBIC better ;)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dbsrgits/dbix-class/pull/61#issuecomment-60145203>.
>

---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class/pull/61#issuecomment-60377705
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20141024/3b6374b3/attachment.htm>