[DBIx-Class-Devel] [sql-translator] Honour DEFERRABLE on all constraints in PostgreSQL (#75)
Peter Rabbitson
notifications at github.com
Tue Nov 3 16:54:48 GMT 2015
> @@ -56,6 +56,7 @@ Object constructor.
> match_type => 'full', # how to match
> on_delete => 'cascade', # what to do on deletes
> on_update => '', # what to do on updates
> + deferrable => 0, # whether to set DEFERRABLE, if supported by the database
@Altreus Ah I now understand. I thought you implemented the deferrable flag as an `{extra}` since it is supported by one and onky one highly non-standard engine. Hence why I was talking about `sqlt_extra` and was confused by how `names` etc applies in the other PR.
I **really** recommend moving this to `extra` like all other non-standard extension, e.g.: https://metacpan.org/pod/SQL::Translator::Producer::MySQL#Extra-attributes
Then the entire not on what is and isn't ignored in https://github.com/dbsrgits/dbix-class/pull/88/files#diff-14a995427a39511927479ae4ffbbb9c7R768 becomes moot.
@ilmari thoughts?
---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-translator/pull/75/files#r43774025
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20151103/afdd89d2/attachment.htm>
More information about the DBIx-Class-Devel
mailing list