[DBIx-Class-Devel] [sql-translator] Add index length option for MySQL (#68)

Peter Rabbitson notifications at github.com
Wed Nov 4 14:14:17 GMT 2015


@castaway thanks for looking - I agree with the *please make a helper function* part.

@abeverley Recall how I was unsure about the name - after reading [various manuals](http://dev.mysql.com/doc/refman/5.7/en/create-index.html) I am now pretty sure `size` would be a mistake, as it is pretty vague. Would you be opposed to renaming the option to `prefix_length`: this way it is both much clearer **and** much more to type, to make a user think (few engines, even within MySQL itself support this, namely only `innodb`). Additionally there are things like `key_block_size` which one may want to specify as well some day, and having already a `size` will be mighty confusing.

I am volunteering to do the renaming work (you've waited long enough on this PR) - I am just making sure you are not opposed to the changes (as you will need to reflect them on your end :/)

---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-translator/pull/68#issuecomment-153732203
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20151104/3a6319cb/attachment.htm>


More information about the DBIx-Class-Devel mailing list