[DBIx-Class-Devel] [dbsrgits/sql-translator] WIP: quoting of identifiers in diff, SQLite and test (#96)

[Ricardo Signes]

In production, we found that the stable CPAN release of the PostgreSQL
producer did not quote identifiers in diffs.  We diagnosed the problem
and wrote a fix, only to see it was fixed in master.  Oh well, we
learned some more about SQLT!

I had adapted my test to run against a few producers, and found that
SQLite didn't work, even in master.  The first cause seemed like the
same bug as I found in PostgreSQL:  add_field did not pass its options
to the generator to inform its quoting.  I have fixed that in the patch,
but it still fails.

The fundamental problem appears to be the weird (to me) `$NO_QUOTES`
behavior.  That variable is set in `->produce`, a method that *does not
seem to be called* in the execution of the test program.  At that point,
I gave up for now, but I wanted to file this issue.
You can view, comment on, or merge this pull request online at:

  https://github.com/dbsrgits/sql-translator/pull/96

-- Commit Summary --

  * WIP: test quoting of identifiers in diff

-- File Changes --

    M lib/SQL/Translator/Producer/SQLite.pm (5)
    A t/XX-quote-diff.t (63)

-- Patch Links --

https://github.com/dbsrgits/sql-translator/pull/96.patch
https://github.com/dbsrgits/sql-translator/pull/96.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-translator/pull/96
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20170922/9db65815/attachment.htm>