[DBIx-Class-Devel] [Perl5/DBIx-Class] Column names can include spaces and other non 'w' characters (#129)

[Daniel Böhmer]

dboehmer commented on this pull request.



> @@ -1531,7 +1531,7 @@ sub reverse_relationship_info {
 sub __strip_relcond {
   +{
     map
-      { map { /^ (?:foreign|self) \. (\w+) $/x } ($_, $_[1]{$_}) }
+      { map { /^ (?:foreign|self) \. (.+) $/x } ($_, $_[1]{$_}) }

While this regex is not DBMS-specific all new allowed characters (all of `\W`) seem to be relevant for MS-SQL only. So I suggest to still limit the allowed characters to those allowed in MS-SQL.

I took a quick look at https://docs.microsoft.com/en-us/sql/odbc/microsoft/column-name-limitations?view=sql-server-2017

* `` ` `` is not allowed
* `|` is not allowed

So I suggest ``[^`|]+``.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/Perl5/DBIx-Class/pull/129#pullrequestreview-177519270
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20181121/83396419/attachment.htm>