[DBIx-Class-Devel] [dbsrgits/dbix-class-schema-loader] this makes oracle materialised views and DDL parse correctly (PR #27)

[Rob Kinyon]

@robkinyon commented on this pull request.



> @@ -415,12 +415,20 @@ sub _dbh_column_info {
 
 sub _view_definition {
     my ($self, $view) = @_;
-
-    return scalar $self->schema->storage->dbh->selectrow_array(<<'EOF', {}, $view->schema, $view->name);
+    my $viewdef = scalar $self->schema->storage->dbh
+        ->selectrow_array(<<'EOF', {}, $view->schema, $view->name);
 SELECT text
 FROM all_views
 WHERE owner = ? AND view_name = ?

I would flip the order of these WHERE clauses so that the parameter lists for both queries are in the same order.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class-schema-loader/pull/27#pullrequestreview-841167842
You are receiving this because you are subscribed to this thread.

Message ID: <dbsrgits/dbix-class-schema-loader/pull/27/review/841167842 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20211228/498fb07f/attachment.htm>