[DBIx-Class-Devel] [Perl5/DBIx-Class] Make t/53lean_startup.t robust wrt stacktrace details (PR #143)

[Leon Timmermans]

This test checks if none of DBIC is loading anything unexpected. It
contains logic to skip over indirect loaders such as base, parent and
Class::C3::Componentised. However, this erroneously skips over direct
dependencies of such classes. In particular, it assigns the MRO::Compat
dependency in Class::C3::Componentised to whatever class it thinks it
loads CCC. Before ad89278 this worked out fine, because it would be
assigned to main, which while meaningless isn't part of DBIx::Class so
ignored. After ad89278, it's assigned to the class that loads CCC, which
is DBIx::Class::Componentised, which is part of DBIC, and hence fails
the test.

This test will cause it to not skip on for any BEGIN blocks inside an
indirect loader, therefor the MRO::Compat dependency will correctly be
assigned to Class::C3::Componentised.
You can view, comment on, or merge this pull request online at:

  https://github.com/Perl5/DBIx-Class/pull/143

-- Commit Summary --

  * Make t/53lean_startup.t robust wrt stacktrace details

-- File Changes --

    M t/53lean_startup.t (2)

-- Patch Links --

https://github.com/Perl5/DBIx-Class/pull/143.patch
https://github.com/Perl5/DBIx-Class/pull/143.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/Perl5/DBIx-Class/pull/143
You are receiving this because you are subscribed to this thread.

Message ID: <Perl5/DBIx-Class/pull/143 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20220219/69dc3387/attachment.htm>