[DBIx-Class-Devel] [dbsrgits/sql-translator] Add index length option for MySQL (#68)

Veesh Goldman notifications at github.com
Wed Jun 21 20:08:41 GMT 2023


I think that the design we settled on is sufficiently encapsulated that we can make changes later.
My first thought is that to handle where the field is really an expression, we should have an `expression` flag in the `extra` hash, which the postgres producer will then use to skip quoting even when it's on. Hopefully it won't be too hard to recognize an expression, I haven't worked on the parsers in a while.

re `uniq` - in my implemenation, i actually removed that, b/c the `fields` of an `Index` need to be coerced into the new `IndexField` objects, so that's handled there. Though i see the logic in not allowing duplicates (allows calling code to be lazy in programatically adding column names or whatever).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-translator/pull/68#issuecomment-1601603518
You are receiving this because you are subscribed to this thread.

Message ID: <dbsrgits/sql-translator/pull/68/c1601603518 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20230621/b0e6e046/attachment.htm>


More information about the DBIx-Class-Devel mailing list