[Dbix-class] JOIN patch and inflate_columns patch

[Matt S Trout]

On 6 Dec 2006, at 18:37, Bernhard Graf wrote:

> Matt S Trout wrote:
>
>>>> ISTR the inflate_column one renamed a method rather than  
>>>> creating an
>>>> inflate_columns method that calls inflate_column as requested; did
>>>> you post a version that implemented it the other way? If so, a link
>>>> to the web archive pointing at the mail where you did so would be
>>>> appreciated since evidently I've missed it.
>>
>>> inflate_columns is downwards compatible to the previous
>>> inflate_column.
>>> After patching inflate_column becomes an alias to inflate_columns.
>>> Which problems do you see with this?
>>
>> What problems did you see with the way I originally proposed
>> implementing it that caused you to do it differently?
>
> I cannot find your posting where you proposed that originally.
>
> Anyway my implementation potentially saves method calls while your
> proposal adds one or more.

A method call at setup time is neither here nor there compared to the  
C3 recompile etc., and it'll leave the code cleaner. It also allows  
for not actually touching the existing inflate_column code.

Please could you just implement it that way? We've probably spent as  
long writing e-mails now as it would've taken you to tweak it as  
requested :)

-- 
Matt S Trout, Technical Director, Shadowcat Systems Ltd.
Offering custom development, consultancy and support contracts for  
Catalyst,
DBIx::Class and BAST. Contact mst (at) shadowcatsystems.co.uk for  
details.
+ Help us build a better perl ORM: http://dbix- 
class.shadowcatsystems.co.uk/ +