[Dbix-class] Re: RFC: Restrict deflation to blessed objects only?

[Matt S Trout]

On 15 Nov 2006, at 19:19, Jess Robinson wrote:

>
>
> On Sun, 29 Oct 2006, Matt S Trout wrote:
>
>> A. Pagaltzis wrote:
>>>  * Jess Robinson <castaway at desert-island.demon.co.uk> [2006-10-28  
>>> 23:55]:
>>> >  On Sat, 28 Oct 2006, A. Pagaltzis wrote:
>>> > >  * Jess Robinson <castaway at desert-island.demon.co.uk>  
>>> [2006-10-28 > >  20:55]:
>>> > > >  Is anyone relying on the fact that deflate currently checks
>>> > > >  for is-ref, and not blessed objects?
>>> > > > >  If the deflater doesnt deref the reference itself, then it
>>> > >  would be hard to rely on that behaviour for anything useful,
>>> > >  in which case Id say you shouldnt even think about it.
>>> > >  ENOPARSE .. Run that by me again?
>>>
>>>  If the code that deflates a reference uses it as an object, then
>>>  passing in a non-object reference wont do anything useful. And
>>>  if thats the case, then its very unlikely that anyone is
>>>  relying on this behaviour, which means you can go ahead and
>>>  change the behaviour without worrying.
>>
>> Yes, yes. Here, have a Stating The Obvious 101 diploma.
>>
>> In the meantime, we were asking if anybody was using a deflator  
>> that accepts a scalarref (and hence surely doesn't use it as an  
>> object) ?
>>
>> Anybody? Bueller?
>
>
> I'd almost forgotten this one.. it seems nobody is yelling, so here  
> we go ;)

Sold. Test it, fix it, trunk it.

-- 
Matt S Trout, Technical Director, Shadowcat Systems Ltd.
Offering custom development, consultancy and support contracts for  
Catalyst,
DBIx::Class and BAST. Contact mst (at) shadowcatsystems.co.uk for  
details.
+ Help us build a better perl ORM: http://dbix- 
class.shadowcatsystems.co.uk/ +