[Dbix-class] Modifying DBIx::Class::Core (collapsing classes)

[John Napiorkowski]

--- Matt S Trout <dbix-class at trout.me.uk> wrote:

> Basically, the reason I've been asking about this is
> that next::method is 
> approx 2*sub call plus a hash lookup overhead (note
> sub call, method calls are 
> marginally more expensive than sub calls).
> 
> Given nobody seems to be using the component in
> isolation, I was wondering 
> about collapsing any next::method stuff into a
> single method, probably in Row. 
> This would make exactly zero difference if
> everybody's only subclassing Core, 
> but would probably give us a noticeable performance
> improvement.
> 
> Thoughts? Comments? Objections?

>From what I can see the main advantage to the way it
is now is that by breaking it up a bit it can help
with code updates and for understanding how it works. 
If you don't think doing this would make it more
difficult in the long run I don't see any downside at
all, and speedups are a definate plus since that's the
big objection I'm getting from some of my clients
(although a lot of it is due to things I need to
optimize, like using prefetch instead of join in
certain places, etc.)

> 
> -- 
>       Matt S Trout       Offering custom
> development, consultancy and support
>    Technical Director    contracts for Catalyst,
> DBIx::Class and BAST. Contact
> Shadowcat Systems Ltd.  mst (at)
> shadowcatsystems.co.uk for more information
> 
> + Help us build a better perl ORM:
> http://dbix-class.shadowcatsystems.co.uk/ +
> 
> _______________________________________________
> List:
>
http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
> Wiki: http://dbix-class.shadowcatsystems.co.uk/
> IRC: irc.perl.org#dbix-class
> SVN:
>
http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
> Searchable Archive:
>
http://www.mail-archive.com/dbix-class@lists.rawmode.org/
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com