[Dbix-class] [PATCH]DBIC::Cursor::Cached's next method has bug.

Matt S Trout dbix-class at trout.me.uk
Tue Aug 7 14:07:31 GMT 2007


On Tue, Aug 07, 2007 at 06:11:58PM +0900, atsushi kobayashi wrote:
> Hi,All
> 
> DBIC::Cursor::Cached is so good!
> but, next method has bug.
> 
> I wrote a patch below:
> 
> $ diff Cached.pm Cached.pm.org
> 37c37
> <   return @{($self->{data} ||= $self->_fill_data)->[$self->{pos}++]||[]};
> ---
> >   return @{($self->{data} ||= $self->_fill_data)->{$self->{pos}++}||[]};
> 
> 
> Does the patch seem good?

... I'm an idiot.

Thanks very much for spotting this.

1.0.1 uploaded to CPAN.

-- 
      Matt S Trout       Need help with your Catalyst or DBIx::Class project?
   Technical Director    Want a managed development or deployment platform?
 Shadowcat Systems Ltd.  Contact mst (at) shadowcatsystems.co.uk for a quote
http://chainsawblues.vox.com/                    http://www.shadowcat.co.uk/ 



More information about the DBIx-Class mailing list