[Dbix-class] param_bind branch

[John Napiorkowski]

--- Matt S Trout <dbix-class at trout.me.uk> wrote:

> I've done some fixing of this; it didn't handle the
> bind attr on an rs 
> correctly so I've tweaked that (thus making
> CDBICompat pass)
> 
> John, the only failing test on there that isn't also
> failing on -current 
> is now ordered.t, can you please have a look at
> that? Once that's 
> working I -think- we're ready to push back to
> -current, though there 
> looks to be some code duplication in terms of source
> => $source->name 
> (which should be ->from anyway ...); I think we'd be
> better doing $ident 
> = $ident->from if blessed($ident) && 
> $ident->isa("DBIx::Class::ResultSource") in _execute
> to a source can be 
> passed to ->select as well, strikes me as being more
> DWIMish.

Yeah, there's some lazy cut and paste I should fix,
are we cool with me making a private method for that? 
Your other suggestions make sense to me.  I'll clean
it up on Wed (USA East Coast time).  Any other
suggestions or  glaring problems please let me know. 
I have a bit of time Wed through the end of the week
to clean up on this.

I'll also check the failing test, probably look at
that later tonight. Thanks for the feedback.

--john

> 
> Brandon and other storage hackers, could you please
> have a quick look at 
> John's changes? They seem fine to me but you guys
> know better.
> 
> _______________________________________________
> List:
>
http://lists.rawmode.org/cgi-bin/mailman/listinfo/dbix-class
> Wiki: http://dbix-class.shadowcatsystems.co.uk/
> IRC: irc.perl.org#dbix-class
> SVN:
>
http://dev.catalyst.perl.org/repos/bast/trunk/DBIx-Class/
> Searchable Archive:
>
http://www.mail-archive.com/dbix-class@lists.rawmode.org/
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com