[Dbix-class] Small patch forDBIx::Class::Storage::DBI::Oracle::Generic (BLOB handling)

[Nickolay Platonov]

Sorry, seems I've missed your replies, I even think that patch was unnoticed
)
Its my 1st experience of contributing something to Open Source project -
quite exciting feeling )

I'll try to provide a test also (currently bit away from Oracle part of my
application) - may be Alex can do it sooner



On Thu, May 29, 2008 at 12:56 PM, Hartmaier Alexander <
Alexander.Hartmaier at t-systems.at> wrote:

> I'm in for testing on Oracle 10.2.0.3.0 on Sun Solaris from a debian 4.0
> box.
>
> -Alex
>
>
> -----Original Message-----
> From: Matt S Trout [mailto:dbix-class at trout.me.uk]
> Sent: Thursday, May 29, 2008 8:08 AM
> To: DBIx::Class user and developer list
> Subject: Re: [Dbix-class] Small patch
> forDBIx::Class::Storage::DBI::Oracle::Generic (BLOB handling)
>
> On Fri, May 16, 2008 at 12:35:29AM +0400, Nickolay Platonov wrote:
> > Hello
> >
> > I've discovered the issue with BLOB column handling with
> > DBIx::Class::Storage::DBI::Oracle::Generic
> > (the column value doesnt want to go into base)
> >
> > the key links:
> >
> >
> http://search.cpan.org/~pythian/DBD-Oracle-1.21/Oracle.pm#Binding_for_Upd=
ates_and_Inserts<http://search.cpan.org/%7Epythian/DBD-Oracle-1.21/Oracle.p=
m#Binding_for_Updates_and_Inserts>
> <
> http://search.cpan.org/%7Epythian/DBD-Oracle-1.21/Oracle.pm#Binding_for_U=
pdates_and_Inserts
> >
> >
> http://search.cpan.org/~pythian/DBD-Oracle-1.21/Oracle.pm#Placeholder_Bin=
ding_Attributes<http://search.cpan.org/%7Epythian/DBD-Oracle-1.21/Oracle.pm=
#Placeholder_Binding_Attributes>
> <
> http://search.cpan.org/%7Epythian/DBD-Oracle-1.21/Oracle.pm#Placeholder_B=
inding_Attributes
> >
> >
> >
> http://search.cpan.org/~ash/DBIx-Class-0.08010/lib/DBIx/Class/Storage/DBI=
.pm#bind_attribute_by_data_type<http://search.cpan.org/%7Eash/DBIx-Class-0.=
08010/lib/DBIx/Class/Storage/DBI.pm#bind_attribute_by_data_type>
> <
> http://search.cpan.org/%7Eash/DBIx-Class-0.08010/lib/DBIx/Class/Storage/D=
BI.pm#bind_attribute_by_data_type
> >
> >
> > And here is a suggesting quick patch, based on info from links:
> >
> >
> > use DBD::Oracle qw(:ora_types);
> >
> >
> > sub bind_attribute_by_data_type {
> >     my ($self,$type) =3D @_;
> >
> >     if ($type eq 'BLOB') {
> >         return { 'ora_type' =3D> SQLT_BIN };
> >     } elsif ($type eq 'CLOB') {
> >         return { 'ora_type' =3D> SQLT_CHR };
> >     } else {
> >         return;
> >     }
> > }
>
> That looks pretty sane. Could you see about adding something to the oracle
> tests to "prove" this works (and let people with different versions verify
> it)
> and then I'll sort you out a commit bit?
>
> --
>      Matt S Trout       Need help with your Catalyst or DBIx::Class
> project?
>   Technical Director
> http://www.shadowcat.co.uk/catalyst/
>  Shadowcat Systems Ltd.  Want a managed development or deployment platfor=
m?
> http://chainsawblues.vox.com/
> http://www.shadowcat.co.uk/servers/
>
> _______________________________________________
> List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
> IRC: irc.perl.org#dbix-class
> SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
> Searchable Archive:
> http://www.grokbase.com/group/dbix-class@lists.rawmode.org
>
>
> _______________________________________________
> List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
> IRC: irc.perl.org#dbix-class
> SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
> Searchable Archive:
> http://www.grokbase.com/group/dbix-class@lists.rawmode.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.scsys.co.uk/pipermail/dbix-class/attachments/20080529/459=
7adac/attachment-0001.htm