[Dbix-class] update on DBIC / SQLA1.50 tests

[Peter Rabbitson]

Dami Laurent (PJ) wrote:
> For info : the latest revision of SQLA1.50
> (http://dev.catalyst.perl.org/svnweb/bast/browse/SQL-Abstract/1.x/branch
> es/1.50_RC/) 
> together with the DBIC patch from mendel (http://scsys.co.uk:8001/20236)
> fixes most problems.
> 
> 
> Still have to look at failures in 
>   t\95sql_maker_quote
> and
>   t\96file_column
> 
> 

t\96file_column does not fail for me, please provide your test output.
Other than that I see the same output. Apart from bracketed mismatches I
have order_by DESC is quoted wrong in 95sql_maker_quote.t

Excellent work so far!

rabbit at Thesaurus:~/devel/dbic/trunk$ PERL5LIB=../../sqla/lib/ prove
-Ilib -v t/95sql_maker_quote.t
t/95sql_maker_quote....1..8
ok 1 - use DBICTest;
not ok 2 - got correct SQL for count query with quoting

#   Failed test 'got correct SQL for count query with quoting'
#   at t/95sql_maker_quote.t line 54.
#          got: 'SELECT COUNT( * ) FROM `cd` `me`  JOIN `artist`
`artist` ON `artist`.`artistid` = `me`.`artist` WHERE ( (
`artist`.`name` = ? AND `me`.`year` = ? ) )'
#     expected: 'SELECT COUNT( * ) FROM `cd` `me`  JOIN `artist`
`artist` ON ( `artist`.`artistid` = `me`.`artist` ) WHERE (
`artist`.`name` = ? AND `me`.`year` = ? )'
not ok 3 - quoted ORDER BY with DESC okay # TODO order_by with quoting
needs fixing (ash/castaway)

#   Failed (TODO) test 'quoted ORDER BY with DESC okay'
#   at t/95sql_maker_quote.t line 81.
#          got: 'SELECT `me`.`cdid`, `me`.`artist`, `me`.`title`,
`me`.`year` FROM `cd` `me` ORDER BY `year DESC`'
#     expected: 'SELECT `me`.`cdid`, `me`.`artist`, `me`.`title`,
`me`.`year` FROM `cd` `me` ORDER BY `year` DESC'
ok 4 - select attr with me.* is right # TODO select attr with star needs
fixing (mst/nate)
ok 5 - did not quote ORDER BY with scalarref
ok 6 - quoted table names for UPDATE
not ok 7 - got correct SQL for count query with bracket quoting

#   Failed test 'got correct SQL for count query with bracket quoting'
#   at t/95sql_maker_quote.t line 181.
#          got: 'SELECT COUNT( * ) FROM [cd] [me]  JOIN [artist]
[artist] ON [artist].[artistid] = [me].[artist] WHERE ( (
[artist].[name] = ? AND [me].[year] = ? ) )'
#     expected: 'SELECT COUNT( * ) FROM [cd] [me]  JOIN [artist]
[artist] ON ( [artist].[artistid] = [me].[artist] ) WHERE (
[artist].[name] = ? AND [me].[year] = ? )'
ok 8 - bracket quoted table names for UPDATE
# Looks like you failed 2 tests of 8.
dubious
	Test returned status 2 (wstat 512, 0x200)
DIED. FAILED tests 2, 7
	Failed 2/8 tests, 75.00% okay
Failed Test           Stat Wstat Total Fail  List of Failed
-------------------------------------------------------------------------------
t/95sql_maker_quote.t    2   512     8    2  2 7
 (1 subtest UNEXPECTEDLY SUCCEEDED).
Failed 1/1 test scripts. 2/8 subtests failed.
Files=1, Tests=8,  1 wallclock secs ( 0.41 cusr +  0.02 csys =  0.43 CPU)
Failed 1/1 test programs. 2/8 subtests failed.


***