[Dbix-class] Re: SQL::Translator conversion from Class::Base to Moo

Dagfinn Ilmari Mannsåker ilmari at ilmari.org
Sun Sep 23 17:28:37 GMT 2012


Peter Rabbitson <rabbit+dbic at rabbit.us> writes:

> On Sun, Sep 23, 2012 at 09:37:43AM -0500, fREW Schmidt wrote:
>> As a followup to this, as things seem to have cooked sufficiently I have
>> cut a minor fix release (0.11013) and rebased ilmari's changes on that
>> and cut a dev release (0.11013_01.)  Assuming there aren't any issues
>> from various smokers we'll probably cut a real release some time next week.
>
> Please review 7 janitorial commits and cut another rel: topic/mooify_cleanup

I disagree with the removal of the version from the 'use Moo'
statements, since that changes a clear error message to a subtle bug.
Just checking at build/test time is insufficient, since an older version
of Moo might sneak in after SQLT was installed.

SQLT doesn't use Dist::Zilla or any other automatic prereq detection, so
your argument against it is moot.

-- 
ilmari
"A disappointingly low fraction of the human race is,
 at any given time, on fire." - Stig Sandbeck Mathisen




More information about the DBIx-Class mailing list