[Dbix-class] View Definitions for non-virtual views

Thomas Sibley trsibley at uw.edu
Wed Aug 2 23:52:36 GMT 2017

On Aug 2, 2017, at 16:38 , Francisco Obispo <francisco at obispo.link> wrote:
> Any thoughts on the PR <https://github.com/dbsrgits/dbix-class-schema-loader/pull/13> ?

Functionally it looks sane to me, by quick inspection.  A few review notes on style and process:

• At the very least, it should be reduced to the single real commit, instead of commit A, revert of A, commit B.
• The maintainers may require you to add tests for this new option.
• The maintainers would likely appreciate if you matched the surrounding code style, particularly with regard to indentation levels and brace hugging.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class/attachments/20170802/669cdfcc/attachment.htm>

More information about the DBIx-Class mailing list