[html-formfu] Possible leak with Catalyst::Controller::HTML::FormFu

[Carl Franks]

Hi,

I've committed the change now, though in future it's best to issue a
github pull request, as it's easier to keep track of things that way.

Cheers,
Carl


On 15 March 2011 09:13, Charlie Garrison <garrison at zeta.org.au> wrote:
> Good evening,
>
> On 15/03/11 at 8:06 AM +0200, Octavian Rasnita <orasnita at gmail.com> wrote:
>
>> I have reported that leak a long time ago and Carl answered with the same
>> solution, but I guess it was not applied to the H::FF trunk.
>>
>> http://www.mail-archive.com/html-formfu@lists.scsys.co.uk/msg02195.html
>
> Thanks, that was the post I was thinking of. (I was too lazy to search for
> it; was quicker to just apply the patch.)
>
>> Your solution is a little more complete though, because it also checks if
>> the reference is not weak.
>
> I just copied that style of weakening $c from elsewhere in the same module.
> It seemed pretty safe to use since it checked isweak first.
>
>
> Carl, will you apply the patch or should I fork the repo and then send a
> pull request?
>
> Thanks,
> Charlie
>
> --
>   Ꮚ Charlie Garrison ♊ <garrison at zeta.org.au>
>
> O< ascii ribbon campaign - stop html mail - www.asciiribbon.org
> 〠  http://www.ietf.org/rfc/rfc1855.txt
>
>
> _______________________________________________
> HTML-FormFu mailing list
> HTML-FormFu at lists.scsys.co.uk
> http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/html-formfu
>