[html-formfu] Dev release with faster test suite

[Carl Franks]

On 11 May 2011 17:49, Moritz Onken <onken at netcubed.de> wrote:
> Hi everyone,
>
> ever since Moose was introduced, the test suite of FormFu took minutes to finish. This is both a pain for developers, because the test run costs valuable time. And installing FormFu is a pain for users because it takes ages.
>
> Instead of running each file individually, Test::Aggregate loads all files and runs them in one process. I modified the Makefile.PL and tests to work properly.
>
> I'd appreciate it if you could try to install the dev release and tell me if everything worked fine. If Test::Aggregate is not installed, it will fall back to the slow installation. So if you could install FormFu without and with T::A installed, that'd be great. There are no functional changes to the 0.09003 release.
>
> The tarball can be downloaded from http://cpan.cpantesters.org/authors/id/P/PE/PERLER/HTML-FormFu-0.09003_01.tar.gz.

Hi,
I've pushed a couple fixes to get all the tests passing under Windows.
However, after I installed Test::Aggregate, I still got test failures.
I think when the formfu test suite was previously using
Test-Aggregate, I got round it by moving some test files into a
separate directory.
I suppose you could also edit t/aggregate.t to just skip when run under windows.
Carl

t/01use.t ........................ ok
t/04basic.t ...................... ok
t/05_repeated_render.t ........... ok
t/aggregate.t .................... 116/378 binmode() on closed filehandle fh0000
2one.txt at C:\Users\cafranks\checkout\tmp\HTML-FormFu-0.09003_01\blib\lib/HTML/
FormFu/Upload.pm line 40.
readline() on closed filehandle fh00002one.txt at C:\Users\cafranks\checkout\tmp
\HTML-FormFu-0.09003_01\blib\lib/HTML/FormFu/Upload.pm line 44.

    #   Failed test at t/elements/file_post.t line 80.
    #          got: undef
    #     expected: 'One
    # '
binmode() on closed filehandle fh00003two.txt at C:\Users\cafranks\checkout\tmp\
HTML-FormFu-0.09003_01\blib\lib/HTML/FormFu/Upload.pm line 40.
readline() on closed filehandle fh00003two.txt at C:\Users\cafranks\checkout\tmp
\HTML-FormFu-0.09003_01\blib\lib/HTML/FormFu/Upload.pm line 44.

    #   Failed test at t/elements/file_post.t line 90.
    #          got: undef
    #     expected: 'Two!
    # '
binmode() on closed filehandle fh00004hello_world.txt at C:\Users\cafranks\check
out\tmp\HTML-FormFu-0.09003_01\blib\lib/HTML/FormFu/Upload.pm line 40.
readline() on closed filehandle fh00004hello_world.txt at C:\Users\cafranks\chec
kout\tmp\HTML-FormFu-0.09003_01\blib\lib/HTML/FormFu/Upload.pm line 44.

    #   Failed test at t/elements/file_post.t line 100.
    #          got: undef
    #     expected: 'Hello World!
    # '
binmode() on closed filehandle fh00005does_not_exist.gif at C:\Users\cafranks\ch
eckout\tmp\HTML-FormFu-0.09003_01\blib\lib/HTML/FormFu/Upload.pm line 40.
readline() on closed filehandle fh00005does_not_exist.gif at C:\Users\cafranks\c
heckout\tmp\HTML-FormFu-0.09003_01\blib\lib/HTML/FormFu/Upload.pm line 44.

    #   Failed test at t/elements/file_post.t line 110.
    #          got: undef
    #     expected: ''
    # Looks like you failed 4 tests of 25.

#   Failed test 'Tests for t/elements/file_post.t'
#   at (eval 4175) line 2.
t/aggregate.t .................... 309/378 binmode() on closed filehandle fh0000
1one.txt at C:\Users\cafranks\checkout\tmp\HTML-FormFu-0.09003_01\blib\lib/HTML/
FormFu/Upload.pm line 40.
readline() on closed filehandle fh00001one.txt at C:\Users\cafranks\checkout\tmp
\HTML-FormFu-0.09003_01\blib\lib/HTML/FormFu/Upload.pm line 44.

    #   Failed test at t/nested/elements/file_post.t line 75.
    #          got: undef
    #     expected: 'One
    # '
    # Looks like you failed 1 test of 8.

#   Failed test 'Tests for t/nested/elements/file_post.t'
#   at (eval 8653) line 2.
t/aggregate.t .................... 357/378 # Looks like you failed 2 tests of 37
8.
t/aggregate.t .................... Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/378 subtests
t/block_insert_after.t ........... ok
t/block_insert_before.t .......... ok
t/field_accessor_loc.t ........... ok
t/field_accessor_loc_arrayref.t .. ok
t/field_change_name.t ............ ok
t/field_id.t ..................... ok
t/multiple_select_fields.t ....... ok
t/multiple_text_fields.t ......... ok

Test Summary Report
-------------------
t/aggregate.t                  (Wstat: 512 Tests: 378 Failed: 2)
  Failed tests:  129, 335
  Non-zero exit status: 2
Files=12, Tests=416, 23 wallclock secs ( 0.45 usr +  0.06 sys =  0.51 CPU)
Result: FAIL
Failed 1/12 test programs. 2/416 subtests failed.
dmake:  Error code 255, while making 'test_dynamic'