[Catalyst] [Patch] Catalyst::Plugin::Authentication::Credential::Password.pm -- typo and debug consistency

Yuval Kogman nothingmuch at woobling.org
Sat Jan 14 19:36:24 CET 2006


Since no one volunteered to make $c->log work the right way WRT
$c->debug yet i'll just commit this as is.

Thanks, Frank, and sorry for taking so long - somehow this became
unflagged in my mailbox

On Mon, Jan 09, 2006 at 15:47:16 +0100, Frank Wiegand wrote:
> This patch fixes a little typo and adds " if $c->debug" to all
> $c->log->debug("...") calls.
> 
> 
> Frank

> Index: Catalyst-Plugin-Authentication/lib/Catalyst/Plugin/Authentication/Credential/Password.pm
> ===================================================================
> --- Catalyst-Plugin-Authentication/lib/Catalyst/Plugin/Authentication/Credential/Password.pm	(Revision 2960)
> +++ Catalyst-Plugin-Authentication/lib/Catalyst/Plugin/Authentication/Credential/Password.pm	(Arbeitskopie)
> @@ -18,7 +18,8 @@
>              || $_->param("username") )
>          {
>              $c->log->debug(
> -                "Can't login a user without a user object or user ID param");
> +                "Can't login a user without a user object or user ID param")
> +                  if $c->debug;
>              return;
>          }
>  
> @@ -26,13 +27,14 @@
>              || $_->param("passwd")
>              || $_->param("pass") )
>          {
> -            $c->log->debug("Can't login a user without a password");
> +            $c->log->debug("Can't login a user without a password")
> +              if $c->debug;
>              return;
>          }
>      }
>  
>      unless ( Scalar::Util::blessed($user)
> -        and $user->isa("Catalyst:::Plugin::Authentication::User") )
> +        and $user->isa("Catalyst::Plugin::Authentication::User") )
>      {
>          if ( my $user_obj = $c->get_user($user) ) {
>              $user = $user_obj;
> @@ -52,8 +54,7 @@
>      }
>      else {
>          $c->log->debug(
> -            "Failed to authenticate user '$user'. Reason: 'Incorrect password'"
> -          )
> +            "Failed to authenticate user '$user'. Reason: 'Incorrect password'")
>            if $c->debug;
>          return;
>      }

> _______________________________________________
> Catalyst mailing list
> Catalyst at lists.rawmode.org
> http://lists.rawmode.org/mailman/listinfo/catalyst


-- 
 ()  Yuval Kogman <nothingmuch at woobling.org> 0xEBD27418  perl hacker &
 /\  kung foo master: /me does a karate-chop-flip: neeyah!!!!!!!!!!!!!!




More information about the Catalyst mailing list