[DBIx-Class-Devel] Pull Request: topic/docs-pod-inherit

[Peter Rabbitson]

On Thu, Dec 13, 2012 at 12:01:37PM -0500, Brendan Byrd wrote:
> > * Please do not throw in "simple" fixes like the $^O win32 stuff
> > into unrelated commits. For example your use of `env` just broke
> > the builder for anyone using local::lib. These things are not trivial,
> > please do not treat them as such. For this particular case - dmake
> > got to have some sort of "I am running under myself" variable - find
> > what it is and use it.
> 
> Well, it breaks right now for anybody not using bash. 

Hm? FOO=bar <command> is a /bin/sh idiom, not bash-specific. In any case
there is a better workaround for the entire thing as noted earlier.

> I don't see why
> env would have anything to do with local::lib; it keeps the %ENV
> intact and adds to it, exactly like the bash shortcut.

Mea culpa, I somehow read it as "use a clean .bashrc-only-like env"
 
> Also, dmake has no such variable.  I compared %ENV between dmake and
> no dmake, and they are the same.

Hmm.. I think I may have a solution for that too.

> 
> > * Your dist somehow is broken inc/ contents are incomplete. Please
> > if possible get me a shell session log. I have only seen you and
> > frew produce such releases - something is going very subtly wrong.
> 
> I'll check it out and see about producing a log.  One thing I noticed
> this morning when I did a "dmake clean" was that inc/ was in a strange
> permission state.  Couldn't access it at all, so I deleted it.
> Hopefully, I can reproduce the situation.
> 

Excellent