[Dbix-class] t/92storage_on_connect_do.t

[Peter Rabbitson]

Dave Howorth wrote:
> Dave Howorth wrote:
>>> And that brings us to the last oddity, which appears to be the cause of
>>> my problem, but again my brain is struggling with why the test doesn't
>>> fail for everybody?
>> ...
>>> So is the test wrong, or the module, or is my brain fried?
>> Can anybody please confirm whether they see this failure or not?
> 
> warnocked again, I see.
> 
> I've done some more poking and now understand why the test doesn't fail
> for everybody. The failing code path is only executed if $self->debug. I
> had DBIC_TRACE set because of my previous problems. If I unset it, the
> test passes.
> 
> So that seems to answer my next question. My brain's not fried; the
> module is broken. To duplicate the problem:
> 
>   DBIC_TRACE=1 make test
> 

Well this would explain the long traces for one. So the right way to fix
the warning tests is to determine if we are in debug mode and match
accordingly. I don't think it is wise to just expand the regexes, since
seeing full traces when they are not requested IS a bug. I can take a
stab at this early next week if no one else fixes it before that.

Out of curiosity - why are you running the test in debug mode?