[Dbix-class] PROPOSAL: merging Haarg's patch and making it easier to do simple merges / emergency fixes

Darren Duncan darren at darrenduncan.net
Sun Jan 14 05:40:07 GMT 2018


I propose that distinct proposals from now on are submitted in separate email 
threads and have independent votes.  John, do you want to do that with these two 
(and also with the subject-to I previously mentioned)? -- Darren Duncan

On 2018-01-13 9:25 PM, Karen Etheridge wrote:
> I vote yes on proposal 1 (https://github.com/dbsrgits/dbix-class/pull/114 should 
> be merged), so long as (as discussed) the documentation is suitably amended to 
> allow such a merge.
> 
> I vote no on proposal 2, to allow immediate merge and release of "obvious" 
> changes.  I would be more likely to support this proposal if it was amended to 
> either allow immediate merges but not release, or only allow *trial* (unindexed) 
> releases. I feel to do an immediate non-trial release requires more oversight at 
> this point still.
> 
> On Fri, Jan 12, 2018 at 8:25 AM, John Napiorkowski wrote:
> 
>     Two proposals for the governing committee
> 
>     First proposal:
> 
>     Haarg proposed a small and obvious fix here =>
>     https://github.com/dbsrgits/dbix-class/pull/114
> 
>     I think it should be merged.
> 
>     Second proposal:
> 
>     Anyone with comaint or first come should be able to merge and release as
>     needed trivial or obvious patches (such as the one Haag proposed),
>     documentation improvements, or fixes required immediately because of
>     security issues or problems with upstream dependencies.  In those cases we
>     can allow to skip voting and merge / release code at once.
> 
>     Regards,
> 
>     John Napiorkowski



More information about the DBIx-Class mailing list